Red Hat Code Browser bug?

Latest response

I would like to find the patch that change #define DRV_VERSION_BUILD 21 in Intel Ethernet driver, so I search as below,
https://access.redhat.com/labs/psb/versions/kernel-3.10.0-514.el7/search?q=%23define+DRV_VERSION_BUILD+21&scope=patch

and I find this patch do that change in the preview window, and that is what I want

kernel-3.10.0-514.el7/netdrv-i40e-i40evf-Bump-i40e-version-to-1-3-25-and-i40evf-to-1-3-17
38 #define DRV_VERSION_MINOR 3
39 -#define DRV_VERSION_BUILD 21
40 +#define DRV_VERSION_BUILD 25
41 #define DRV_VERSION __stringify(DRV_VERSION_MAJOR) "." \

But once I click the link on the top of the preview window to see the patch content
https://access.redhat.com/labs/psb/versions/kernel-3.10.0-514.el7/patches/netdrv-i40e-i40evf-Bump-i40e-version-to-1-3-25-and-i40evf-to-1-3-17

There is no DRV_VERSION_BUILD change in the patch content. Why?

Ken Kuo's picture

Responses

Good question. There's a couple of places where we've changed the build version to 21:

$ git log --oneline drivers/net/ethernet/intel/i40evf/i40evf_main.c | egrep "\.21$"
b93904f [netdrv] i40e/i40evf: Changed version from 1.6.19 to 1.6.21
c193a82 [netdrv] i40e/i40evf: Bump i40e to 1.3.34 and i40evf to 1.3.21

That last one is not released yet:

$ git describe --contains b93904f
kernel-3.10.0-604.el7~32

It's possible this is due to multiple commits which are squished into the one RPM patch file?

I'll reach out to the team who make the Portal Source Browser.

I spoke to the PSB team about this. They're aware that this diff-to-patch resolution is not perfect at the moment, and added this report to their internal issue tracker.

To set an expectation, the Portal Source Browser is not a focus area for the team at the moment so it will probably be quite some time before this is looked at, if at all.

Thanks a lot for your help, due to this issue, is there any service or subscription available to access the patch set directly(git? tarball?) instead of through Portal Source Browser? I'd like to purchase such a service.

I'm sorry, there is no such offering for a per-patch repo, that is internal only.

We commit directly into the CentOS git repository, and you can rebuild kernel SRPMs that way: https://wiki.centos.org/Sources

I realise that doesn't achieve your aim but it is the only official offering to non-customers. Customers get access to signed SRPMs but still no per-patch tree.

Was this helpful?

We appreciate your feedback. Leave a comment if you would like to provide more detail.
It looks like we have some work to do. Leave a comment to let us know how we could improve.
Close

Welcome! Check out the Getting Started with Red Hat page for quick tours and guides for common tasks.